refactor(webapp): upgrade node version to 19.4 #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `"nan": "2.17.0"` to package.json resolutions.
- Add `"nan": "2.17.0"` to package.json resolutions.
Tirokk
previously requested changes
Jan 28, 2023
There was a problem hiding this comment.
Superb! 😍
Works for me in general!!!
Except the Maintenance I upgraded …
I:
- upgraded the Node version in the maintenance as well
- upgraded the Node version in main folder as well
- added
"nan": "2.17.0"to package.json resolutions - I tested it on docker with an error for maintenance, see below, but everything else works
Please:
- udate the Node version in webapp readme after merging refactor(backend): node 19 with fixed image upload #5897 , in case
Error on my execution of docker compose up --build:
- there's an error running
docker compose up --buildwith the maintenance mode. would be nice if you could have a look, see screen shot. old Node version does work for me - switching the language does not work for me. was the same before …
Mogge
approved these changes
Feb 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
upgrade node version to 19.4
Issues
latestnowv18.13.0? #5902Todo