Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(backend): update jest #5964

Merged
merged 7 commits into from
Feb 14, 2023
Merged

refactor(backend): update jest #5964

merged 7 commits into from
Feb 14, 2023

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Feb 13, 2023 •
edited
Loading

🍰 Pullrequest

update jest to 29.4

Issues

Todo

  • None

@Mogge Mogge self-assigned this Feb 13, 2023
ulfgebhardt
ulfgebhardt reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good that we identified the problem - dangling neode handles.
But can't we autoclose those?
The way you implement it the problem will reappear over and over again, whenever someone misses to close a handle. Can't we find a way to autoclose it?

@Mogge Mogge merged commit 284b7cc into master Feb 14, 2023
@Mogge Mogge deleted the backend-update-jest branch February 14, 2023 12:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

Assignees

@Mogge Mogge

Labels
refactor service: backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔧 [Refactor] Does Avatar Testing In Backend Make Sense This Way?
2 participants
@Mogge @ulfgebhardt