Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(webapp): fix donation bar blink #6107

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Conversation

maeckes1
Copy link
Contributor

@maeckes1 maeckes1 commented Mar 9, 2023

🍰 Pullrequest

Sets the default value for showing the donation bar to false, to avoid blinking.

Issues

Todo

  • None

@maeckes1 maeckes1 added this to the 🏃 The Sprint after that... milestone Mar 9, 2023
@maeckes1 maeckes1 self-assigned this Mar 9, 2023
@maeckes1 maeckes1 requested a review from Tirokk March 9, 2023 12:03
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the webapp unit test:
https://github.com/Ocelot-Social-Community/Ocelot-Social/actions/runs/4374162960/jobs/7653539481

Just set the donation default text and test to check for the new default.

Run $ yarn test or more specific $yarn test pages/index.spec.js in the webapp folder.

@maeckes1 maeckes1 requested a review from Tirokk March 13, 2023 09:47
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @maeckes-infinitylabs

nicely done and works fine. 😍

I approve 🚀💫

Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Tirokk Tirokk merged commit 387d70a into master Mar 14, 2023
@Tirokk Tirokk deleted the 5982-fix-donation-bar-blink branch March 14, 2023 14:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Solve Short Time Blinking Donation Bar On News Feed
3 participants