Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(backend): notifications for groups #6150

Merged
merged 20 commits into from
Mar 18, 2023

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Mar 16, 2023

Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todos create Ticket for:

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some errors @Mogge , but had no time yet to write them down.

Please contact me.

As examples:

  • just seed the db
    • login as Bob
    • visit the School group profile
    • see the join/leave button has the identifier, see screenshot
    • click the leave button and get a 500 error page
      • same if I join again afterwards

Bildschirmfoto 2023-03-17 um 09 51 22

Bildschirmfoto 2023-03-17 um 09 59 26

Questions:

Message type on add memeber to a group

  • A member just added to a group by an owner gets informed that their rolle in the group has changed. Would we have them informed that they are added to a group, because otherwise they think that they were already member, but got not aware of it or have forgotten?
    • Make a follow up issue or do it here?

Bildschirmfoto 2023-03-17 um 10 39 49

Adjust the information on a notification

  • Would it be thinkable or okay for you, if we add the group descriptionExcerpt as the notification.from.contentExcerpt to the notifications? Because then we have it similar to the posts and comments and could use kind of Description: ${notification.from.contentExcerpt} to make clear what it is.
    • Make a follow up issue or do it here?

Bildschirmfoto 2023-03-17 um 07 51 01

ulfgebhardt
ulfgebhardt previously approved these changes Mar 17, 2023
@ulfgebhardt ulfgebhardt dismissed their stale review March 17, 2023 12:41

Not tested

@Tirokk Tirokk self-requested a review March 17, 2023 17:44
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mogge

very cool done dear! 😍

I approve 🚀🚀🚀💫💫

PS: Just one little suggestion.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
4 participants