-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(backend): notifications for groups #6150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todos create Ticket for:
- Change notification tab height to match buttons => 🐛 [Bug] Webapp – Notification Menu – If Menu is Small Button has Wrong Position #6146
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found some errors @Mogge , but had no time yet to write them down.
Please contact me.
As examples:
- just seed the db
- login as Bob
- visit the
School
group profile - see the join/leave button has the identifier, see screenshot
- click the leave button and get a
500
error page- same if I join again afterwards
Questions:
Message type on add memeber to a group
- A member just added to a group by an owner gets informed that their
rolle in the group has changed
. Would we have them informed that they areadded to a group
, because otherwise they think that they were already member, but got not aware of it or have forgotten?- Make a follow up issue or do it here?
Adjust the information on a notification
- Would it be thinkable or okay for you, if we add the group
descriptionExcerpt
as thenotification.from.contentExcerpt
to the notifications? Because then we have it similar to the posts and comments and could use kind ofDescription: ${notification.from.contentExcerpt}
to make clear what it is.- Make a follow up issue or do it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰 Pullrequest
Issues
Todo