Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(other): github cache in workflow #6604

Merged
merged 21 commits into from
Jul 19, 2023
Merged

fix(other): github cache in workflow #6604

merged 21 commits into from
Jul 19, 2023

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented Jul 18, 2023

🍰 Pullrequest

Fix vulnerabilities that have come into our CI through the workflow refactoring.

  • allow manual re-run of failed jobs with intact workflow cache (do not delete cache, if a preceeding job failed)

    05_fail_of_backend_unit_tests_not_triggering_cache_delete_job

    06_rerun_backend_unit_tests_is_restoring_correct_cache

  • handle cache cleanup to avoid "cache thrashing"

Todo

  • use runner id for distinguishable cache naming
  • run cache deletion job only, if
    • workflow's file change condition is true
    • needed preceding jobs ran successfully
  • add recommended branch cache cleanup at pr closing workflow

Thanx @ulfgebhardt for the good hints.

@ulfgebhardt ulfgebhardt requested a review from mahula July 18, 2023 15:39
@ulfgebhardt ulfgebhardt self-assigned this Jul 18, 2023
@Elweyn Elweyn added bug Something isn't working refactor github_actions Pull requests that update GitHub Actions code labels Jul 18, 2023
@mahula mahula requested review from Mogge and Elweyn and removed request for mahula July 18, 2023 20:56
@Elweyn Elweyn merged commit 4d70358 into master Jul 19, 2023
@Elweyn Elweyn deleted the fix-runner branch July 19, 2023 05:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants