Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pin FluentAssertions to v7 #902

Closed
wants to merge 2 commits into from
Closed

Conversation

YuKitsune
Copy link
Contributor

@YuKitsune YuKitsune commented Jan 28, 2025

[sc-101162]

FluentAssertions v8 changes to a non-open-source license; Commercial Use requires a paid subscription at $129 USD per developer per year.

This PR pins the version of FluentAssertions to 7.0.0.

@YuKitsune YuKitsune requested a review from a team January 28, 2025 02:57
@YuKitsune YuKitsune requested a review from borland January 28, 2025 05:28
Copy link
Contributor

@borland borland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the the [7.1.0] might not be the ideal solution, it's what the other teams are doing; good stuff, let's merge this and worry about finer detail later.

@YuKitsune
Copy link
Contributor Author

Closing this as Dependabot, Renovate and Rider do not respect NuGet version ranges in csproj files.
We should instead configure our dependency upgrader (Dependabot/Renovate) to prevent upgrades beyond v7.

@YuKitsune YuKitsune closed this Jan 30, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants