Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Respect leaderboard-count config #560

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Respect leaderboard-count config #560

merged 2 commits into from
Feb 13, 2025

Conversation

FireML
Copy link
Contributor

@FireML FireML commented Feb 10, 2025 •
edited
Loading

What has changed?

  • The competition leaderboard now respects the leaderboard-count config in the messages file.
  • Renamed Messages class to MessageConfig to match the other config classes

Related Issues

Closes #557

Checklist

  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation as needed.
  • I have added any labels that fit this PR.

@sarhatabaot sarhatabaot added bug: fixed A bug that has been fixed. optimizations (readability) Readability improvements labels Feb 10, 2025
sarhatabaot
sarhatabaot approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@sarhatabaot sarhatabaot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sarhatabaot sarhatabaot merged commit d32d920 into Oheers:master Feb 13, 2025
@FireML FireML deleted the leaderboard branch February 14, 2025 12:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sarhatabaot sarhatabaot sarhatabaot approved these changes

Assignees
No one assigned
Labels
bug: fixed A bug that has been fixed. optimizations (readability) Readability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: leaderboard show all fishing players
2 participants
@FireML @sarhatabaot