Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Plant Notes #217

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add Plant Notes #217

wants to merge 11 commits into from

Conversation

NewsGuyTor
Copy link

@NewsGuyTor NewsGuyTor commented Jan 27, 2025

I've implemented Plant Notes! 🎉

This adds the backend stuff ofc, I've also submitted a PR for lovelace-flower-card, it's here: Olen/lovelace-flower-card#161. Plant notes are configured as normal in Configure.

plant notes

Multiline is supported in the plant notes.

I've also added all languages too (Translate translated, but should be fine).

Take a look - I'll correct any issues! 🙂

@Olen
Copy link
Owner

Olen commented Jan 29, 2025

Hi, thanks for the PR.
I understand and appreciate the idea, but I am not 100% sure of the implementation.
Adding this as an "option" does not really sound like the correct way of doing it.
I think adding this as e.g. an input_text would be a better solution.

@NewsGuyTor
Copy link
Author

Ah, that makes sense, I'll get on that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants