Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Power users should not be notified by email of an auto approval #4431

Closed
sephrat opened this issue Dec 7, 2021 · 3 comments · Fixed by #4432
Closed

Power users should not be notified by email of an auto approval #4431

sephrat opened this issue Dec 7, 2021 · 3 comments · Fixed by #4432

Comments

@sephrat
Copy link
Contributor

sephrat commented Dec 7, 2021

Describe the bug
As an admin, I receive a "Request Approved" email notification when my own request is (automatically) approved. I believe this is unnecessary noise since there's no reason for my request to be denied given my rights.

To Reproduce

  1. Setup email notifications for event "Request Approved"
  2. As an admin, request an item
  3. You receive a notification stating that your request has been approved

Expected behavior
Automatic approvals should not trigger a notification to the user.

Ombi Version:

  • Version 4.7.6
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Hi!

Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.

Have you looked at the wiki yet? https://docs.ombi.app/

Before posting make sure you also read our FAQ.

Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.

If we need more information or there is some progress we tag the issue or update the tag and keep you updated.

Thanks!

Ombi Bot.

@tidusjar
Copy link
Member

tidusjar commented Dec 7, 2021

Yeah you make a fair point. Marked as a bug

@sephrat
Copy link
Contributor Author

sephrat commented Dec 8, 2021

Looking at the code, the issue seems to narrow down to TV notifications only. Also, you need to toggle a setting to prevent notifications from being sent (except if you're an admin).
I'll work on a fix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants