Media sync refactoring #4552
Closed
Media sync refactoring #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After mulling it over for a month, I will close this PR. I have no intention of continuing this work as I find my current progress not as clean as I wanted it to be, and the next steps feel too overwhelming for too little gain. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still very much WIP but I wanted to share what I've been up to.
This is an attempt at merging common logic between Emby/Plex/Jellyfin sync. The idea is to not repeat Ombi logic across all media servers sync, and only leave the API and media-server-specific part in the dedicated class.
Once again (#4463) I underestimated the complexity of the task so the end result is not as satisfying as I expected. I'm hoping to streamline some stuff by the end of the PR.
Hopefully this will help future maintenance (I'm looking at #4472 2nd proposed solution).