Merge pull request #1869 from OmniSharp/bugfix/returntype

fixed return type condition in LSP completions

CHANGELOG.md

@@ -4,6 +4,7 @@ All changes to the project will be documented in this file.
 ## [1.36.0] - Not yet released
 * Fixed debugging in .NET 5 preview SDKs ([omnisharp-vscode#3459](https://github.com/OmniSharp/omnisharp-vscode/issues/3459), PR: [#1862](https://github.com/OmniSharp/omnisharp-roslyn/pull/1862))
 * Introduced a new `/quickinfo` endpoint to provide a richer set of information compared to `/typeinfo`. Consumers are encouraged to use it as their hover provider ([#1808](https://github.com/OmniSharp/omnisharp-roslyn/issues/1808), PR: [#1860](https://github.com/OmniSharp/omnisharp-roslyn/pull/1860))
+* Fixed return type in LSP completion handler ([#1864](https://github.com/OmniSharp/omnisharp-roslyn/issues/1864), PR: [#1869](https://github.com/OmniSharp/omnisharp-roslyn/pull/1869))
 
 ## [1.35.4] - 2020-07-22
 * Update to Roslyn `3.8.0-1.20357.3` (PR: [#1849](https://github.com/OmniSharp/omnisharp-roslyn/pull/1849))

src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCompletionHandler.cs

@@ -100,7 +100,7 @@ public async override Task<CompletionList> Handle(CompletionParams request, Canc
                 var completionItem = new CompletionItem
                 {
                     Label = response.CompletionText,
-                    Detail = !string.IsNullOrEmpty(response.ReturnType) ?
+                    Detail = string.IsNullOrEmpty(response.ReturnType) ?
                             response.DisplayText :
                             $"{response.ReturnType} {response.DisplayText}",
                     Documentation = response.Description,