Detect legacy ASP.NET Websites via project GUID #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Jan 17, 2018
There was a problem hiding this comment.
Thanks @filipw! This is definitely the right fix. The GUID you used is the correct one: https://github.com/Microsoft/msbuild/blob/d026eba43c429802f14ad4bfe57b18e56d2519c7/src/Build/Construction/Solution/SolutionFile.cs#L81.
|
thanks - it's green now, so I will merge this to unclog the PR pipeline a bit |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1066.
I just noticed the logic there wasn't sufficient as these projects don't necessarily start with
http://- for example it could belocalhostor any other string really (up to the user).However, the legacy ASP.NET Websites have a common well-known project GUID so we can use that to exclude it from OmniSharp (since they don't have csproj files, we can't support them at the moment).
I threw in a test just to be on the safe side.