Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade http driver to latest ASP.NET Core version when running in .NET 6 #2446

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

mispencer
Copy link
Contributor

The HTTP driver is currently using ASP.NET Core 2.2. This reached its end of life in Dec 2019, almost 3 years ago.

This PR updates to the latest ASP.NET core version.

ASP.NET Core 3 and later do not support .NET framework, so this only applies to the build for .NET 6 (and later when supported)

Fixes #2259

@dnfadmin
Copy link

dnfadmin commented Sep 4, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, thank you

@mispencer
Copy link
Contributor Author

Is there anything further I need to do to get this merged?

@filipw filipw enabled auto-merge September 9, 2022 08:19
@filipw filipw merged commit 6135214 into OmniSharp:master Sep 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.NullReferenceException throw in v1.37.12 to v1.37.16 when access /checkreadystatus endpoint
3 participants