Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create GitHub releases for merges into main #2628

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Aug 13, 2024

sequenceDiagram
  autonumber
  Maintainer ->> GitHub: Merges PR into the `master` branch
  GitHub --) OmniSharp ADO: Merge to `master` triggers pipeline
  activate OmniSharp ADO
  OmniSharp ADO ->> GitHub: Pulls source for omnisharp-roslyn
  note over OmniSharp ADO: Calculates a build version
  OmniSharp ADO ->> GitHub: Creates a draft release and `v#35;.#35;.#35;-beta.#35;` tag
  deactivate OmniSharp ADO
  GitHub --) OmniSharp ADO: `v*` tag creation triggers pipeline
  activate OmniSharp ADO
  OmniSharp ADO ->> GitHub: Pulls source for omnisharp-roslyn
  note over OmniSharp ADO: Builds packages for various platforms
  OmniSharp ADO ->> GitHub: Adds packages to release and unmark as draft
  deactivate OmniSharp ADO
Loading

curl -L https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
sudo apt-get install apt-transport-https
sudo apt-get update && sudo apt-get install azure-cli
az storage blob upload-batch --destination "releases" --source "$(System.ArtifactsDirectory)/deployment/" --overwrite --account-name roslynomnisharp --account-key $BLOB_KEY
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will no longer push artifacts to this storage account.

publishVstsFeed: Builds/omnisharp
allowPackageConflicts: true
condition: and(succeeded(), or(startsWith(variables['Build.SourceBranch'], 'refs/tags/v'), eq(variables['Build.SourceBranch'], 'refs/heads/master')))
# Temporarily disable publishing to nuget.org while we attempt to renew authentication.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reenabled pushing to NuGet for official builds.


stages:
- stage: CreateBetaReleaseTag
displayName: "Tag Beta Release"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running against master branch no longer builds artifacts directly. Instead it creates a draft release and tag which will then cause this pipeline to build a prerelease.

paths:
exclude:
- 'CHANGELOG.md'
pr: none
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a "build" pipeline in GH actions which performs the same steps that this pipeline did for PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch protections rules have been updated accordingly.

@@ -1,26 +1,11 @@
parameters:
- name: testProjects
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because this pipeline hasn't run unit tests in years.

@JoeRobich JoeRobich merged commit 00ed931 into master Aug 14, 2024
16 checks passed
@JoeRobich JoeRobich deleted the dev/jorobich/create-beta-releases branch August 14, 2024 05:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants