feat(atoms)!: remove createdAt timestamp tracking (#150)

Omnistac · Jan 7, 2025 · 28102e4 · 28102e4
1 parent 681af78
commit 28102e4
Show file tree

Hide file tree

Showing 13 changed files with 9 additions and 113 deletions.
diff --git a/packages/atoms/src/classes/GraphNode.ts b/packages/atoms/src/classes/GraphNode.ts
@@ -695,7 +695,6 @@ export class ExternalNode extends GraphNode {
     this.i = source
 
     addEdge(this, source, {
-      createdAt: this.e._idGenerator.now(),
       flags,
       operation: operation,
     })

diff --git a/packages/atoms/src/classes/IdGenerator.ts b/packages/atoms/src/classes/IdGenerator.ts
@@ -22,10 +22,9 @@ export class IdGenerator {
    * Generate an id that is guaranteed to be unique in this ecosystem and
    * pretty-much-guaranteed to be unique globally.
    *
-   * This method and `IdGenerator#now()` are the only methods in Zedux that
-   * produce random values.
+   * This method is the only method in Zedux that produces random values.
    *
-   * Override these when testing to create reproducible graphs/dehydrations that
+   * Override this when testing to create reproducible graphs/dehydrations that
    * can be used easily in snapshot testing. See our setup in the Zedux repo at
    * `<repo root>/packages/react/test/utils/ecosystem.ts` for an example.
    */
@@ -69,22 +68,6 @@ export class IdGenerator {
     })
   }
 
-  /**
-   * Generate a timestamp. Pass true to make it a high res timestamp if possible
-   *
-   * This method and `IdGenerator#generateId()` are the only methods in Zedux
-   * that produce random values.
-   *
-   * Override these when testing to create reproducible graphs/dehydrations that
-   * can be used easily in snapshot testing. See our setup in the Zedux repo at
-   * `<repo root>/packages/react/test/utils/ecosystem.ts` for an example.
-   */
-  public now(highRes?: boolean) {
-    return highRes && typeof performance !== 'undefined'
-      ? performance.now()
-      : Date.now()
-  }
-
   private cacheClass(instance: { new (): any }) {
     let id = this.weakCache.get(instance)
     if (id) return id

diff --git a/packages/atoms/src/classes/instances/AtomInstance.ts b/packages/atoms/src/classes/instances/AtomInstance.ts
@@ -178,7 +178,6 @@ export class AtomInstance<
    * @see Signal.c
    */
   public c?: Cleanup
-  public _createdAt: number
   public _injectors?: InjectorDescriptor[]
   public _isEvaluating?: boolean
   public _nextInjectors?: InjectorDescriptor[]
@@ -204,7 +203,6 @@ export class AtomInstance<
     public readonly p: G['Params']
   ) {
     super(e, id, undefined) // TODO NOW: fix this undefined
-    this._createdAt = e._idGenerator.now()
   }
 
   /**

diff --git a/packages/atoms/src/types/index.ts b/packages/atoms/src/types/index.ts
@@ -320,7 +320,6 @@ export interface GraphEdgeConfig {
 
 // TODO: optimize this internal object to use single-letter properties
 export interface GraphEdge {
-  createdAt: number
   flags: number // calculated from the EdgeFlags
   operation: string
 

diff --git a/packages/atoms/src/utils/evaluationContext.ts b/packages/atoms/src/utils/evaluationContext.ts
@@ -33,6 +33,8 @@ export interface EvaluationContext {
  */
 let evaluationContext: EvaluationContext = {}
 
+const perf = typeof performance === 'undefined' ? Date : performance
+
 /**
  * In the current buffer, draw a new edge between the currently evaluating graph
  * node and the passed node. This is how automatic dependencies are created
@@ -47,14 +49,13 @@ export const bufferEdge = (
   operation: string,
   flags: number
 ) => {
-  const { e, s } = evaluationContext.n!
+  const { s } = evaluationContext.n!
   const existingEdge = s.get(source)
 
   if (existingEdge) {
     if (flags < (existingEdge.p || OutOfRange)) existingEdge.p = flags
   } else {
     s.set(source, {
-      createdAt: e._idGenerator.now(),
       flags: OutOfRange, // set to an out-of-range flag to indicate a new edge
       p: flags,
       operation,
@@ -86,12 +87,11 @@ export const destroyBuffer = (
 }
 
 const finishBuffer = (previousNode?: GraphNode, previousStartTime?: number) => {
-  const { _idGenerator, _mods, modBus } = evaluationContext.n!.e
+  const { _mods, modBus } = evaluationContext.n!.e
 
   if (_mods.evaluationFinished) {
-    const time = evaluationContext.s
-      ? _idGenerator.now(true) - evaluationContext.s
-      : 0
+    const time = evaluationContext.s ? perf.now() - evaluationContext.s : 0
+
     const action: ActionFactoryPayloadType<
       typeof pluginActions.evaluationFinished
     > = { node: evaluationContext.n!, time }
@@ -174,6 +174,6 @@ export const startBuffer = (node: GraphNode) => {
   evaluationContext.n = node
 
   if (node.e._mods.evaluationFinished) {
-    evaluationContext.s = node.e._idGenerator.now(true)
+    evaluationContext.s = perf.now()
   }
 }
diff --git a/packages/react/test/__snapshots__/types.test.tsx.snap b/packages/react/test/__snapshots__/types.test.tsx.snap
@@ -6,17 +6,14 @@ exports[`react types signals 1`] = `
     "className": "Signal",
     "observers": {
       "no-1": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
       "no-2": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
       "no-3": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -31,7 +28,6 @@ exports[`react types signals 1`] = `
     "observers": {},
     "sources": {
       "@signal-0": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -45,7 +41,6 @@ exports[`react types signals 1`] = `
     "observers": {},
     "sources": {
       "@signal-0": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -59,7 +54,6 @@ exports[`react types signals 1`] = `
     "observers": {},
     "sources": {
       "@signal-0": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },

diff --git a/packages/react/test/integrations/__snapshots__/selection.test.tsx.snap b/packages/react/test/integrations/__snapshots__/selection.test.tsx.snap
@@ -6,14 +6,12 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "no-1": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
     },
     "sources": {
       "@@selector-common-name-0": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
@@ -27,15 +25,13 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "SelectorInstance",
     "observers": {
       "1": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
       },
     },
     "sources": {
       "root": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -50,7 +46,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "observers": {},
     "sources": {
       "1": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -63,7 +58,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "@@selector-common-name-0": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -83,14 +77,12 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "no-3": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
     },
     "sources": {
       "@@selector-common-name-2": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
@@ -104,15 +96,13 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "SelectorInstance",
     "observers": {
       "2": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
       },
     },
     "sources": {
       "root": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -127,7 +117,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "observers": {},
     "sources": {
       "2": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -140,7 +129,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "@@selector-common-name-2": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -160,14 +148,12 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "no-4": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
     },
     "sources": {
       "@@selector-common-name-0": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
@@ -181,14 +167,12 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "no-3": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
     },
     "sources": {
       "@@selector-common-name-2": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
@@ -202,15 +186,13 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "SelectorInstance",
     "observers": {
       "1": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
       },
     },
     "sources": {
       "root": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -224,15 +206,13 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "SelectorInstance",
     "observers": {
       "2": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
       },
     },
     "sources": {
       "root": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -247,7 +227,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "observers": {},
     "sources": {
       "2": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -261,7 +240,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "observers": {},
     "sources": {
       "1": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -274,13 +252,11 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "@@selector-common-name-0": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
       },
       "@@selector-common-name-2": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -300,14 +276,12 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "no-4": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
     },
     "sources": {
       "@@selector-common-name-0": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
@@ -321,15 +295,13 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "SelectorInstance",
     "observers": {
       "1": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "select",
         "p": undefined,
       },
     },
     "sources": {
       "root": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,
@@ -344,7 +316,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "observers": {},
     "sources": {
       "1": {
-        "createdAt": 123456789,
         "flags": 3,
         "operation": "on",
       },
@@ -357,7 +328,6 @@ exports[`selection same-name selectors share the namespace when destroyed and re
     "className": "AtomInstance",
     "observers": {
       "@@selector-common-name-0": {
-        "createdAt": 123456789,
         "flags": 0,
         "operation": "get",
         "p": undefined,