Skip to content

Commit

Permalink
Removed legacy functions
Browse files Browse the repository at this point in the history
The `SimpleIntListToTbl` and `Split` functions were previously used by stored procedures to parse string delimited lists of e.g. attributes into temporary tables. In a previous update to the schema, this functionality was replaced with user-defined table-valued types—namely `TopicList` and `AttributeValues`, and thus these are no longer utilized.

While these were indroduced previously, they were never publicly documented and we have no expectation that implementers will be calling these directly. As such, while this is technically a breaking change, I'm considering that acceptable since these should be understood to be internal objects, and were never called directly by the OnTopic library. Further, there is no need to call them from application code, as their use is of exclusively benefit to SQL scripts themselves.
  • Loading branch information
JeremyCaney committed Sep 9, 2020
1 parent 0aa3b6e commit f0e781b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 95 deletions.
53 changes: 0 additions & 53 deletions OnTopic.Data.Sql.Database/Functions/SimpleIntListToTbl.sql

This file was deleted.

40 changes: 0 additions & 40 deletions OnTopic.Data.Sql.Database/Functions/Split.sql

This file was deleted.

2 changes: 0 additions & 2 deletions OnTopic.Data.Sql.Database/OnTopic.Data.Sql.Database.sqlproj
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@
<Build Include="Views\VersionHistoryIndex.sql" />
<Build Include="Functions\GetParentID.sql" />
<Build Include="Functions\GetTopicID.sql" />
<Build Include="Functions\SimpleIntListToTbl.sql" />
<Build Include="Functions\Split.sql" />
<Build Include="Stored Procedures\MoveTopic.sql" />
<Build Include="Stored Procedures\UpdateTopic.sql" />
<Build Include="Stored Procedures\UpdateRelationships.sql" />
Expand Down

0 comments on commit f0e781b

Please # to comment.