Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bug: ConsolidateVersions stored procedure doesn't address TopicReferences, Relationships #75

Closed
JeremyCaney opened this issue Mar 30, 2021 · 1 comment
Closed

Bug: ConsolidateVersions stored procedure doesn't address TopicReferences, Relationships #75

JeremyCaney opened this issue Mar 30, 2021 · 1 comment
Assignees
@JeremyCaney
Labels
Area: SQL Relates to the SQL Server database objects; do not use for the repository. Priority: 0 Severity 2: Major Status 5: Complete Task is considered complete, and ready for deployment. Type: Bug Behavior that is inconsistent with documented or expected behavior.
Milestone
OnTopic 5.1.0

Comments

@JeremyCaney
Copy link
Member

The ConsolidateVersions stored procedure will compress the Attributes and ExtendedAttributes tables by consolidating all versions from a given time range into a single version. When we introduced versioning to TopicReferences and Relationships, however, the ConsolidateVersions stored procedure wasn't updated to account for this functionality. This needs to be resolved to ensure that versions are properly compressed across the board.
@JeremyCaney JeremyCaney added Type: Bug Behavior that is inconsistent with documented or expected behavior. Area: Repositories Relates to the `ITopicRepository` interface or one of its implementations. Severity 2: Major Priority: 0 Status 3: In Progress Currently being worked on. labels Mar 30, 2021
@JeremyCaney JeremyCaney added this to the OnTopic 5.1.0 milestone Mar 30, 2021
@JeremyCaney JeremyCaney self-assigned this Mar 30, 2021
JeremyCaney added a commit that referenced this issue Mar 30, 2021
@JeremyCaney
Ensure ConsolidateVersions addresses TopicReferences
7e322c0 
`TopicReferences` operate virtually identically to `Attributes`, and can use the same SQL with minor adjustments. This addresses the `TopicReferences` portion of #75.
JeremyCaney added a commit that referenced this issue Mar 30, 2021
@JeremyCaney
Ensure ConsolidateVersions addresses Relationships
b8c5d09 
`Relationships` operate a bit different than `TopicReferences` (7e322c0) since it is _expected_ that there will be multiple values per `Source_TopicID` and `RelationshipKey`; instead, updates are tracked via the `IsDeleted` column. This addresses the `Relationships` portion of #75.
JeremyCaney added a commit that referenced this issue Mar 30, 2021
@JeremyCaney
Merge branch 'bugfix/association-versioning' into develop
3552bf6 
There were a number of bugs in how association versioning—i.e., versioning of `TopicReferences` and `Relationships`—was addressed as part of the migration and utility scripts, which this update resolves.

This includes:
- Setting the `Version` as part of the `TopicReferences` migration (#70, d041eae)
- Setting the `Version` as part of the `Relationships` migration (#74, 2ec30da)
- Consolidating the `TopicReferences` as part of `ConsolidateVersions` (#75, 7e322c0)
- Consolidating the `Relationships` as part of `ConsolidateVersions` (#75, b8c5d09)
@JeremyCaney JeremyCaney added Status 5: Complete Task is considered complete, and ready for deployment. and removed Status 3: In Progress Currently being worked on. labels Mar 30, 2021
@JeremyCaney
Copy link
Member Author

Support for consolidating TopicReferences (7e322c0) and Relationships (b8c5d09) has been introduced into the ConsolidateVersions stored procedure (3552bf6). Currently, the [Utilities] stored procedures are not covered by unit tests.

@JeremyCaney JeremyCaney added Area: SQL Relates to the SQL Server database objects; do not use for the repository. and removed Area: Repositories Relates to the `ITopicRepository` interface or one of its implementations. labels Apr 3, 2021
@JeremyCaney JeremyCaney mentioned this issue Apr 7, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JeremyCaney JeremyCaney

Labels
Area: SQL Relates to the SQL Server database objects; do not use for the repository. Priority: 0 Severity 2: Major Status 5: Complete Task is considered complete, and ready for deployment. Type: Bug Behavior that is inconsistent with documented or expected behavior.
Projects
None yet
Milestone
OnTopic 5.1.0
Development

No branches or pull requests
1 participant
@JeremyCaney