Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove old notification system #76

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

theEvilReaper
Copy link

Proposed changes

The implementation of notifications (Advancement) was recently reworked and migrated to a new system. The old system has been deprecated, and a migration period was provided. This pull request aims to fully remove the old system

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper requested a review from a team as a code owner September 19, 2024 17:58
Copy link

sonarcloud bot commented Sep 19, 2024

@theEvilReaper theEvilReaper merged commit 346a221 into master Sep 19, 2024
7 checks passed
@theEvilReaper theEvilReaper deleted the remove/notification branch October 1, 2024 11:16
TheMeinerLP pushed a commit that referenced this pull request Oct 31, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants