Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added administration.config #1

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Added administration.config #1

merged 10 commits into from
Dec 20, 2023

Conversation

yash-pal1
Copy link
Contributor

@yash-pal1 yash-pal1 commented Dec 18, 2023 •
edited
Loading

No description provided.

@yash-pal1 yash-pal1 added the type: feature New feature or request label Dec 18, 2023
@yash-pal1 yash-pal1 self-assigned this Dec 18, 2023
@yash-pal1 yash-pal1 requested a review from abhi1693 December 18, 2023 14:05
@abhi1693 abhi1693 changed the title Config module completed Added administration.config Dec 19, 2023
abhi1693
abhi1693 requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@abhi1693 abhi1693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 lines missed in the unit coverage and also do not commit the __pycache__ folder

@abhi1693
added missing docstring
435cfbc
@abhi1693
Merge remote-tracking branch 'origin/master' into Config
c0a8af8 
# Conflicts:
#	docs/administration.rst
#	jelastic/api/administration/__init__.py
#	tests/unit/test_api/test_administration.py
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
941 941 100% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
jelastic/api/administration/init.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 04d43d1 by action🐍

@github-actions GitHub Actions
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
889 887 100% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
jelastic/api/administration/init.py 99% 🟢
TOTAL 99% 🟢

updated for commit: c0a8af8 by action🐍

@yash-pal1 yash-pal1 requested a review from abhi1693 December 20, 2023 04:35
abhi1693
abhi1693 requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@abhi1693 abhi1693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coerage is a 99% as per the report. Please recheck and add the missing test

@yash-pal1 yash-pal1 requested a review from abhi1693 December 20, 2023 11:35
@yash-pal1
Copy link
Contributor Author

Test coerage is a 99% as per the report. Please recheck and add the missing test

sir missing test cases added

@abhi1693 abhi1693 merged commit df31690 into master Dec 20, 2023
10 checks passed
@abhi1693 abhi1693 deleted the Config branch December 20, 2023 13:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@abhi1693 abhi1693 abhi1693 approved these changes

Assignees

@yash-pal1 yash-pal1

Labels
type: feature New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-pal1 @abhi1693