Ag/refactoring #26
Open
Ag/refactoring #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the basic address claiming logic. Needs still needs to be attached to the driver.
Moved a lot of the address claim logic into the control_function file. Cleaned up todos involving CanId encoding when creating address claim messages. Removed some clippy allows. Changed some manual bitshifting to use to_le_bytes. Changed some raw integers to be "Pgn" "Address" and other types in driver. Still WIP
…ager additions Changed CFs to be stored differently. Added a function to send a CAN message. Added a way to create an ICF. Started adding receive message processing.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here my refactoring mentioned in #25