Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[01/15/2023] add: MongoURI for all Environments #161

Merged
merged 4 commits into from
Jan 16, 2023
Merged

[01/15/2023] add: MongoURI for all Environments #161

merged 4 commits into from
Jan 16, 2023

Conversation

RealRichi3
Copy link
Member

Summary

MONGO_URI is the database connection string for the MongoDB database. Each Node environment should connect to a different database.
i.e

  • for test environment, connect to the database for testing
  • for development environment, connect to database for development
  • for production environment, connect to the production database

List of changes proposed in this PR (pull-request)

  • Add MONGO URI for each environment
  • Update config.js imports for new variables
  • Update server.js connection to handle different connection strings

@RealRichi3 RealRichi3 added enhancement New feature or request backend-dev inprogress PR is still work in progress labels Jan 15, 2023
@the-label-bot the-label-bot bot added kind/feature kind/feature size/M size/M labels Jan 15, 2023
@the-label-bot
Copy link

the-label-bot bot commented Jan 15, 2023 •
edited
Loading

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.527 ✔️
Size M 0.969 ✔️

@RealRichi3
Copy link
Member Author

@BatoolMM, please review

BatoolMM
BatoolMM approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@BatoolMM BatoolMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, can you also update .env in the keybase?

@RealRichi3 RealRichi3 merged commit 46c64ba into Open-Science-Community-Saudi-Arabia:backend_dev Jan 16, 2023
@RealRichi3
Copy link
Member Author

Alright @BatoolMM

@RealRichi3 RealRichi3 deleted the fix/Mongo_URL branch January 17, 2023 14:19
@RealRichi3 RealRichi3 mentioned this pull request Jan 21, 2023
Merged
RealRichi3 added a commit to RealRichi3/MOOCs that referenced this pull request Feb 21, 2023
@RealRichi3
Merge pull request Open-Science-Community-Saudi-Arabia#161 from RealR…
f6b8773 
…ichi3/fix/Mongo_URL

[01/15/2023] add: MongoURI for all Environments
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BatoolMM BatoolMM BatoolMM approved these changes

Assignees
No one assigned
Labels
backend-dev enhancement New feature or request inprogress PR is still work in progress kind/feature kind/feature size/M size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealRichi3 @BatoolMM