Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature request / Bug] Keyboard Accelerators are triggered without ALT keypress. #117

Closed
Hadden89 opened this issue Dec 11, 2018 · 6 comments
Assignees

Comments

@Hadden89
Copy link

Hadden89 commented Dec 11, 2018

A key press could be treated as a keyboard accelerator instead as part of the search.
An option to disable the function - which I don't use - will be nice :)

@AveYo
Copy link

AveYo commented Dec 12, 2018

You should use Show search box with Access normally and Selected by default checked.
That way, I don't find an issue with Tab

@Hadden89
Copy link
Author

Hadden89 commented Dec 12, 2018

Both options were checked.
//EDIT: Actually, any key seems to trigger the issue. Look post below.

@Hadden89 Hadden89 changed the title Option to disable tabbed navigation [Feature request] Option to disable tabbed navigation Dec 12, 2018
@Hadden89
Copy link
Author

Hadden89 commented Dec 13, 2018

Ok, the issue is becoming awkard. How I replicated:

  1. Press start menu button;
  2. Menu will be opened;
  3. Press one of these: a number, a letter or the Tab key without focusing the search box.
  4. Some links will have an underlined letter (this should happen only if you press ALT before).
  5. As my OpenShell is localized, Shutdown is Arresta.
    When I press A on keyboard, is treated as ALT+A (shutdown command).

I hope there's a settings to prevent this or to disable the ALT + function in openshell.
There's a kind of workaround, but I'd like to avoid editing INI files. (But probably I have to do it).

It seems I solved editing ExplorerL10N.ini and StartMenuL10N.ini removing any ampersand(&) and now I'm not seeing any "forced" shutdown.

While I won't ask to remove a feature (will be silly), just implement a way to ignore the & in INI files (keyboard accelerators) or to require an ALT before their activation :)

@Hadden89 Hadden89 changed the title [Feature request] Option to disable tabbed navigation [Feature request / Bug] Disabling Keyboard Accelerators Dec 13, 2018
@AveYo
Copy link

AveYo commented Dec 13, 2018

First of all I do not dismiss the existence of a bug, since start items do get alt highlighted along the way.
My initial suggestion is to work around that, yet you do exactly the opposite trying to "mitigate it".
Select by default makes the search box get the input focus so any key, even Tab press is going there and not at the start menu items!
Want to launch an item instead of search? - Just press Alt+Key or navigate with ArrowUP or ArrowDOWN !
It's a no-brainer, who would not want that behavior?!

Granted, that's how OpenShell works for me. Worth a shot to try my shared optimized profile.

@Hadden89
Copy link
Author

Hadden89 commented Dec 13, 2018

@AveYo Well, now it works as (I) expected, is what counts. And after all I followed the suggestion ^^
I left the replication procedure just in case someone else see a similar issue.
Actually I tried various combination but still had the nasty alt highlighting - 3 shutdown within 5 minutes, during the test - but for what I know could be also an awkard w10 bug.
Obviously, I'll check your optimized profile too. OpenShell is built around optimization, after all :P

@Hadden89 Hadden89 changed the title [Feature request / Bug] Disabling Keyboard Accelerators [Feature request / Bug] Keyboard Accelerators Triggered without ALT keypress. Dec 20, 2018
@Hadden89 Hadden89 changed the title [Feature request / Bug] Keyboard Accelerators Triggered without ALT keypress. [Feature request / Bug] Keyboard Accelerators are triggered without ALT keypress. Dec 20, 2018
@Sam-Hall
Copy link

I've been using Classic Shell for years and now Open Shell, always with the "Select by default" option. I want to confirm that even with this option, sometimes accelerators still get triggered. Maybe the search box gets focus slightly after accelerator events start listening or maybe there's a race condition at play. Either way, an option to disable the accelerators entirely or require Alt to be pressed in conjunction would be much appreciated. I don't think I've ever used the accelerators on purpose, but they have triggered on accident from time to time.

ge0rdi added a commit that referenced this issue Dec 21, 2022
With the option enabled keyboard accelerators will be triggered only if Alt key
is pressed as well.

This is how typical Windows keyboard accelerators work, to avoid
confusion with regular key presses.

Fixes #117
ge0rdi added a commit that referenced this issue Dec 21, 2022
With the option enabled keyboard accelerators will be triggered only if Alt key
is pressed as well.

This is how typical Windows keyboard accelerators work, to avoid
confusion with regular key presses.

Fixes #117
ge0rdi added a commit that referenced this issue Dec 23, 2022
With the option enabled keyboard accelerators will be triggered only if Alt key
is pressed as well.

This is how typical Windows keyboard accelerators work, to avoid
confusion with regular key presses.

Fixes #117
ge0rdi added a commit that referenced this issue Dec 23, 2022
With the option enabled keyboard accelerators will be triggered only if Alt key
is pressed as well.

This is how typical Windows keyboard accelerators work, to avoid
confusion with regular key presses.

Fixes #117
ge0rdi added a commit that referenced this issue Dec 24, 2022
With the option enabled keyboard accelerators will be triggered only if Alt key
is pressed as well.

This is how typical Windows keyboard accelerators work, to avoid
confusion with regular key presses.

Fixes #117
ge0rdi added a commit that referenced this issue Dec 25, 2022
With the option enabled keyboard accelerators will be triggered only if Alt key
is pressed as well.

This is how typical Windows keyboard accelerators work, to avoid
confusion with regular key presses.

Fixes #117
ge0rdi added a commit that referenced this issue Dec 27, 2022
With the option enabled keyboard accelerators will be triggered only if Alt key
is pressed as well.

This is how typical Windows keyboard accelerators work, to avoid
confusion with regular key presses.

Fixes #117
@ge0rdi ge0rdi self-assigned this Dec 27, 2022
@ge0rdi ge0rdi closed this as completed in 23a1dc7 Dec 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants