Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix warn: declaration of 'vring_rsc' shadows a previous local #439

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

xiaoxiang781216
Copy link
Collaborator

@xiaoxiang781216 xiaoxiang781216 commented Nov 6, 2022

 regressed by commit 03c80a13417f67f94852cf7d5cb160f1bdf8271e
    Author: Tammy Leino <tammy_leino@mentor.com>
    Date:   Mon Sep 26 08:14:35 2022 -0700
    
        handle_vdev_rsc must return error if notifyid cannot be assigned
    
        Updated handle_vdev_rsc to return error if a unique id cannot be assigned
        Signed-off-by: Tammy Leino <tammy_leino@mentor.com>

regressed by commit 03c80a1
Author: Tammy Leino <tammy_leino@mentor.com>
Date:   Mon Sep 26 08:14:35 2022 -0700

    handle_vdev_rsc must return error if notifyid cannot be assigned

    Updated handle_vdev_rsc to return error if a unique id cannot be assigned
    Signed-off-by: Tammy Leino <tammy_leino@mentor.com>

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks!
We need to add add the -Wshadow build flag in our test environment

Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@arnopo arnopo merged commit 3a9119d into OpenAMP:main Nov 14, 2022
@arnopo
Copy link
Collaborator

arnopo commented Nov 14, 2022

I also updated the v2022.10 branch, we will create a 2022.10.1 tag with a version 1.3.1 at the end of the month to fix the release

@xiaoxiang781216 xiaoxiang781216 deleted the warn branch November 14, 2022 12:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants