Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Typescript-Angular] modelFileSuffix change dots '.' to slashes '/' #1467

Closed
VincentSurelle opened this issue Nov 16, 2018 · 3 comments
Closed

Comments

@VincentSurelle
Copy link

Description

I'm trying to generate typescript-angular api client with pet store sample.
I installed openapi-generator with Homebrew and got version 3.3.3.

When I try to generate with modelFileSuffix='.model' with kebab-case my dot is changed to a slash.
When I try to generate the same but with camelCase, it simply does not appear.

Here is a sample output :

capture d ecran 2018-11-16 a 12 22 25

openapi-generator version

3.3.3

OpenAPI declaration file content or url

https://raw.githubusercontent.com/openapitools/openapi-generator/master/modules/openapi-generator/src/test/resources/3_0/petstore.yaml

Command line used for generation

openapi-generator generate -i https://raw.githubusercontent.com/openapitools/openapi-generator/master/modules/openapi-generator/src/test/resources/3_0/petstore.yaml -g typescript-angular --additional-properties supportsES6=true,ngVersion='5.2.11',modelSuffix='Model',modelFileSuffix='k.djfgdlmodel' -o ./ts-client-generated-angular

Steps to reproduce

Launch the command above 👼

Related issues/PRs

#418

Suggest a fix/enhancement

73162cb (Maybe sanitize is responsible for it ?)

@wing328
Copy link
Member

wing328 commented Nov 20, 2018

@VincentSurelle thanks for reporting the issue. My guess is that convertUsingFileNamingConvention is converting dot to slash.

Was it working for you before the commit 73162cb ?

cc @smasala

@tomvangreen
Copy link
Contributor

I'm having a similar issue. I'm using the model file suffix .vm and the generated filename is model_vm.ts instead of model.vm.ts. I think this might be related.

@karismann
Copy link
Contributor

this issue can be closed as i actually tested it with 4.0.0 and it work

@wing328 wing328 closed this as completed May 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants