Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(rust,client): re-enable TLS support for reqwest with supportAsync #10439

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

PiDelport
Copy link
Contributor

@PiDelport PiDelport commented Sep 21, 2021

The existing reqwest codegen disables the default reqwest crate features when supportAsync=true: this inadvertently has the effect of disabling reqwest's TLS support entirely.

This PR keeps the default features, which matches the behaviour of supportAsync=false, and keeps the default TLS support enabled.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)

This avoids disabling TLS support entirely.
This avoids disabling TLS support entirely.
@wing328
Copy link
Member

wing328 commented Sep 22, 2021

@wing328
Copy link
Member

wing328 commented Sep 22, 2021

LGMT. Thanks for the enhancement.

@wing328 wing328 merged commit de95e2a into OpenAPITools:master Sep 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants