Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue 11731 #11732

Closed
wants to merge 4 commits into from
Closed

Fix issue 11731 #11732

wants to merge 4 commits into from

Conversation

networkinss
Copy link
Contributor

@networkinss networkinss commented Feb 27, 2022

Fixes #11731.
Added a test in:
src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
doGenerateMediatypes()
including the test openapi yaml in:
src/test/resources/3_0/spring/issue_11731.yaml
Fix is in the spring mustache file:
src/main/resources/JavaSpring/methodBody.mustache
line 9 & 11.

PR checklist

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

Done and commited.

@cachescrubber (2022/02)
@welshm (2022/02)
@MelleD (2022/02)
@atextor (2022/02)
@manedev79 (2022/02)
@javisst (2022/02)
@borsch (2022/02)
@banlevente (2022/02)

  ./mvnw clean package
  ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
@networkinss
Copy link
Contributor Author

My fix is not correct yet.
If works if there is just one mediatype.
But it fails for multiple media types, as could be seen for the failed sample generations.
My mustace experience is probably unsufficient to make it correct now.

@tamershahin
Copy link

this is quite crucial for us.. is there any plan to resume the work on it?

@networkinss
Copy link
Contributor Author

I can give it another try in the next days.

@tamershahin
Copy link

I can give it another try in the next days.

pls have a look here it looks like @borsch may help you there :)

This pull request was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Spring] Default interfaces do not contain response mediatypes except application/json
2 participants