Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[R] Add import in the namespace file #12372

Merged
merged 2 commits into from
May 17, 2022
Merged

[R] Add import in the namespace file #12372

merged 2 commits into from
May 17, 2022

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 15, 2022

Add import in the namespace file to address the following message:

* checking dependencies in R code ... NOTE
Namespaces in Imports field not imported from:
  ‘R6’ ‘base64enc’ ‘httr’ ‘jsonlite’
  All declared Imports should be used.
  • No change in functionality
  • Tested locally

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @Ramanth (2019/07) @saigiridhar21 (2019/07)

@wing328 wing328 marked this pull request as ready for review May 15, 2022 13:52
@wing328 wing328 merged commit 13496aa into master May 17, 2022
@wing328 wing328 deleted the r-namespec-import branch May 17, 2022 02:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant