Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Java] fix JsonCreator with JsonNullable #12813

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

borsch
Copy link
Member

@borsch borsch commented Jul 9, 2022

Fix for #12790

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02)

@borsch borsch force-pushed the fix-jsoncreator-with-nullable branch from 116277f to 68797c5 Compare July 11, 2022 17:22
@borsch borsch closed this Jul 11, 2022
@borsch borsch reopened this Jul 11, 2022
@borsch borsch force-pushed the fix-jsoncreator-with-nullable branch from 68797c5 to cd3261f Compare July 11, 2022 17:51
@wing328 wing328 added this to the 6.1.0 milestone Jul 12, 2022
@wing328 wing328 merged commit 4bbfa01 into OpenAPITools:master Jul 12, 2022
@borsch borsch deleted the fix-jsoncreator-with-nullable branch July 12, 2022 06:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants