Added serialization support for typescript on complex object headers. #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
sruehl
commented
Jan 10, 2019
samples/client/petstore/typescript-axios/builds/with-complex-headers/api.ts
Outdated
Show resolved
Hide resolved
sruehl
commented
Jan 10, 2019
samples/client/petstore/typescript-axios/builds/with-complex-headers/api.ts
Outdated
Show resolved
Hide resolved
wing328
reviewed
Mar 25, 2019
modules/openapi-generator/src/main/resources/typescript-axios/api.mustache
Outdated
Show resolved
Hide resolved
integrate feedback from OpenAPITools#1874 (comment)
|
@sruehl could you fix the conflicts? |
added 2 commits
July 25, 2019 10:19
…ng-serilazation # Conflicts: # bin/typescript-axios-petstore-all.sh # modules/openapi-generator/src/main/resources/typescript-axios/api.mustache
|
@macjohnny I merged the upstream master and fixed the merge after that. Additionally I re-ran the |
macjohnny
reviewed
Jul 25, 2019
modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache
Outdated
Show resolved
Hide resolved
macjohnny
reviewed
Jul 25, 2019
macjohnny
reviewed
Jul 25, 2019
modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache
Outdated
Show resolved
Hide resolved
macjohnny
reviewed
Jul 25, 2019
modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache
Outdated
Show resolved
Hide resolved
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
|
@sruehl can you re-generate the samples, please? |
|
@macjohnny done (as allways forgot to rerun |
|
the failing build is because of kotlin, seems like this is not related to this PR... |
|
@sruehl can you please merge the current master? the CI build failure should be fixed |
|
@sruehl thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553 |
wing328
changed the title
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
When using headers which are defined as complex objects we need to render them as json
fixes #1865
cc: @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)