Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix/activate helidon versionutil tests #18815

Merged

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jun 1, 2024

Contrary to Junit5, classes containing TestNG tests need to have public visibility, otherwise the tests will not be discovered and run.

This PR fixes the visibility and refactors the test code for readability. Adds to #18627

@tjquinno

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Philzen Philzen force-pushed the bugfix/activate-helidon-versionutil-tests branch from bc9d8a4 to df0e3de Compare June 1, 2024 00:55
Philzen added 3 commits June 2, 2024 12:33
Contrary to Junit5, classes containing TestNG tests need to have
public visibility, otherwise the tests will not be discovered and run.
@Philzen Philzen force-pushed the bugfix/activate-helidon-versionutil-tests branch from df0e3de to ad3e000 Compare June 2, 2024 10:35
@Philzen
Copy link
Contributor Author

Philzen commented Jun 2, 2024

@wing328 Rebased and ready to merge

@wing328 wing328 added this to the 7.7.0 milestone Jun 2, 2024
@wing328 wing328 merged commit 051abb8 into OpenAPITools:master Jun 2, 2024
15 checks passed
welshm pushed a commit to welshm/openapi-generator that referenced this pull request Jun 5, 2024
* Reactivate tests

Contrary to Junit5, classes containing TestNG tests need to have
public visibility, otherwise the tests will not be discovered and run.

* Reformat tests for readability

* Rewrite tests using fluent assertions
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants