-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(php-nextgen-client): add support for streaming #19192
feat(php-nextgen-client): add support for streaming #19192
Conversation
6e0186f
to
e4f61d1
Compare
Hi, @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon Are any of you available for a review? Thanks |
e4f61d1
to
45d7a90
Compare
...penapi-generator/src/test/java/org/openapitools/codegen/php/PhpNextgenClientCodegenTest.java
Outdated
Show resolved
Hide resolved
can you please review the test failures? i could repeat the issue locally when testing the output
|
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
45d7a90
to
a4a53bb
Compare
@wing328 I've fixed you feedbacks, can you review it again please. Thanks |
please update the samples when you've time |
…ming Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
2b73da0
to
f71d439
Compare
@wing328 it's done (I've updated the branch with master in the same time) |
looks good. let's give it a try. thanks for the PR |
php-nextgen client:
Add support for streaming file (https://spec.openapis.org/oas/latest.html#considerations-for-file-uploads)
Basically returning " Psr\Http\Message\StreamInterface" instead of "SplFileObject"
PR checklist
Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
(For Windows users, please run the script in Git BASH)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch:
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jebentier
@dkarlovi
@mandrean
@jfastnacht
@ybelenko
@renepardon