Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

scala-cask fix: Added support for 'additionalProperties:true' #19767

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

aaronp
Copy link
Contributor

@aaronp aaronp commented Oct 3, 2024

additionalProperties means the request can contain arbitrary additional properties, and so this change adds an 'additionalProperties' field to request objects which is a json type.

PR checklist

  • [ x] Read the contribution guidelines.
  • [x ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

additionalProperties means the request can contain arbitrary
additional properties, and so this change adds an 'additionalProperties'
field to request objects which is a json type.
@aaronp
Copy link
Contributor Author

aaronp commented Oct 3, 2024

Hello @Bouillie / @chameleon82 / @clasnake

Apologies for the spam - I'm just following the "tag tech committee members" instruction for this PR to the scala-cask generator

Many many thanks in advance!

@aaronp
Copy link
Contributor Author

aaronp commented Oct 5, 2024

Thanks @wing328 so much as ever for your time and great comments! I've made an update to coincide w/ the conversation, so hopefully that makes sense

@wing328 wing328 modified the milestones: 7.9.0, 7.10.0 Oct 8, 2024
@wing328
Copy link
Member

wing328 commented Oct 9, 2024

thanks for the PR

let's give it a try

@wing328 wing328 merged commit 31be9b9 into OpenAPITools:master Oct 9, 2024
27 checks passed
@aaronp aaronp deleted the ci branch October 22, 2024 14:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants