Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Kotlin] Allow other content-types when only interested in status-code / Unit #19801

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

roelwuytens-androme
Copy link
Contributor

This PR addresses a specific issue we noticed with the Kotlin generator when the API returns a content type other than JSON.

For example express JS will return "OK" with response-type text/plain

res.sendStatus(200)

This results in an exception when parsing the response body (see https://github.com/OpenAPITools/openapi-generator/blob/v7.8.0/samples/client/petstore/kotlin-nullable/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt#L188)
We're only interested in success/failure:

      responses:
        '200':
          description: Updated

To solve this we've added a check on Unit.

Technical Committee Kotlin:
@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@4brunu
Copy link
Contributor

4brunu commented Oct 7, 2024

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@roelwuytens-androme
Copy link
Contributor Author

roelwuytens-androme commented Oct 7, 2024

Thanks for the quick feedback!
I've updated my account, and the commits are now linked to my GitHub account, thanks for the link.

@4brunu 4brunu merged commit 7d1e999 into OpenAPITools:master Oct 7, 2024
58 checks passed
@4brunu
Copy link
Contributor

4brunu commented Oct 7, 2024

Merged 👍 thanks for contributing to this project

@wing328 wing328 added this to the 7.10.0 milestone Nov 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants