-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[cpprestsdk] Implement Enum inside Objects #19919
Conversation
… methods inside openapi-generator/modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/modelbase-header.mustache, have also be added two missing body of methods definitions
can you please add a test or 2 in |
let's give it a try. i will file a PR later to improve the code format a bit. thanks for the PR |
Sorry but I have been very busy these weeks. Thanks for taking care of code enhancement!
|
yes please
yes please open a separate PR for easier review thanks again for your contributions |
[#8937 #958(actually already closed)]
I added the support for
enum
type inside objects. They can be stand alone or inside vectors.Set
of enums doesn't compile in favor of vectors(if necessary can be supported, if you think that set of enums are useful).Map
with enums will be as before.Other then the yaml/json from the issues I used:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd