Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump libraries for Kotlin client. #20053

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

sylwester-zielinski
Copy link
Contributor

@sylwester-zielinski sylwester-zielinski commented Nov 7, 2024

It's a libraries bump for Kotlin multiplatform client side.

Main changes are Ktor bump to 3.0.1 and Kotlin to 2.0.21.
Adapts to new API as it has been done here.

There was one issue with runTest function in Coroutine.kt file for JS after Kotlin bump.
This function had internal modifier in commonTest and no usage so I assumed it's a legacy thing and deleted it.

Kotlin Committee:
@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylwester-zielinski, thanks for the PR. LGTM

@4brunu
Copy link
Contributor

4brunu commented Nov 8, 2024

Thanks for creating this PR.
Looks good to me.
CI Failure is not related to this PR.

@4brunu 4brunu merged commit 3a36882 into OpenAPITools:master Nov 8, 2024
59 of 60 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants