Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Trim the input of operationId filter in OpenAPINormalizer (#20186) #20189

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Trim the input of operationId filter in OpenAPINormalizer (#20186) #20189

merged 1 commit into from
Nov 30, 2024

Conversation

danielalmqvist
Copy link
Contributor

@danielalmqvist danielalmqvist commented Nov 26, 2024

#20186

Additional test added to test the trim-functionality.

Generation Details
FILTER=operationId: addPet| getPetById

Steps to reproduce
Use openapiNormalizer and FILTER and set them on separate lines.
Expected the operationIdFilters to contain addPet and getPetById.
Actually the operationIdFilters contains addPet and \n\t\t\t\t\t\t\tgetPetById

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Nov 30, 2024

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@danielalmqvist
Copy link
Contributor Author

thank you, updated the commiter now

@wing328 wing328 merged commit 88be078 into OpenAPITools:master Nov 30, 2024
15 checks passed
@wing328
Copy link
Member

wing328 commented Nov 30, 2024

thanks for the PR, which has been merged

@wing328 wing328 added Enhancement: General OpenAPI Normalizer Normalize the spec for easier processing labels Nov 30, 2024
@wing328 wing328 added this to the 7.11.0 milestone Nov 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Enhancement: General OpenAPI Normalizer Normalize the spec for easier processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants