Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(typescript): remove incorrect file extensions #20194

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 27, 2024

url, http, and https are Node.js core modules, and form-data should be loaded using a bare specifier. This commit removes the file extensions from these imports.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

url, http, and https are Node.js core modules, and form-data
should be loaded using a bare specifier. This commit removes
the file extensions from these imports.
import { URL, URLSearchParams } from 'url{{importFileExtension}}';
import * as http from 'http{{importFileExtension}}';
import * as https from 'https{{importFileExtension}}';
import {{^supportsES6}}* as{{/supportsES6}} FormData from "form-data";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOI: why do the other * as do not have this guard? Oversight?

@macjohnny
Copy link
Member

@cjihrig please re-generate the samples

@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 29, 2024

please re-generate the samples

I think this is done in 5e28c01.

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 2, 2024

@macjohnny it looks like the CI passed. Is there anything else that I need to do?

@macjohnny macjohnny merged commit 06f0b68 into OpenAPITools:master Dec 2, 2024
19 checks passed
@cjihrig cjihrig deleted the ts-http branch December 2, 2024 15:01
@wing328 wing328 added this to the 7.11.0 milestone Dec 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants