Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[csharp][generichost] Fixes de/serialization #20540

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Jan 25, 2025

I could not duplicate the reported issue from #20105, however, that issue did point out another issue which is fixed here. So I think we can say this fixes #20105

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs devhl-labs changed the title fixed json serializer [csharp][generichost] Fixes de/serialization Jan 25, 2025
@wing328 wing328 added this to the 7.12.0 milestone Jan 26, 2025
@wing328 wing328 merged commit f1c1567 into OpenAPITools:master Jan 26, 2025
58 checks passed
@devhl-labs devhl-labs deleted the fix-json-serializer branch January 26, 2025 16:46
balassit pushed a commit to balassit/openapi-generator that referenced this pull request Feb 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Csharp] distriminator property in subclass generated incorrect in the class constructor
2 participants