Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Rust] Fixed Rust default isAnyType causing compiler issues. #20631

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

ranger-ross
Copy link
Contributor

This PR fixes an issue where types with an unknown type where not templated properly causing a compiler error. (see issue linked below)

The approach to fix this is to default unknown types for path, query and header params to String instead of serde_json::Value.
The rational is that it is quiet rare for json to be passed in non-body params.

fixes #18526


PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro

@ranger-ross ranger-ross changed the title Fixed Rust default isAnyType causing compiler issues. [Rust] Fixed Rust default isAnyType causing compiler issues. Feb 10, 2025
@wing328
Copy link
Member

wing328 commented Feb 10, 2025

can you please review the build failure when you've time?

https://github.com/OpenAPITools/openapi-generator/actions/runs/13242785126/job/36961850037?pr=20631

you may need to manually remove the auto-generated test file and regenerate the samples again (run it twice)

@ranger-ross
Copy link
Contributor Author

Sorry, looks like there is a test in thread_test.rs that needs to be updated manually.

Just pushed a commit that should fix CI

@wing328 wing328 added this to the 7.12.0 milestone Feb 11, 2025
@wing328 wing328 merged commit 9ed15a1 into OpenAPITools:master Feb 11, 2025
20 checks passed
@wing328
Copy link
Member

wing328 commented Feb 11, 2025

thanks for the fix, which has been merged

@ranger-ross ranger-ross deleted the fix-model-json branch February 11, 2025 05:03
kgeilmann pushed a commit to kgeilmann/openapi-generator that referenced this pull request Feb 14, 2025
…PITools#20631)

* Fixed Rust default `isAnyType` causing compiler issues.

* Added tests for Rust isAnyType's

* Fixed thread_test.rs
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][RUST] Parameter with empty schema produces invalid rust code
3 participants