Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[csharp][generichost] fix syslib1045, use GeneratedRegex for .net7+ #20695

Merged

Conversation

ffabss
Copy link
Contributor

@ffabss ffabss commented Feb 19, 2025

Changed the ClientUtils of the generichost to use GeneratedRegex for the JsonRegex that checks if the content-type is JSON-like.
Since .NET 7 Source Generation can be used for Regex and now will be used for at least the JsonRegex of ClientUtils.
I also changed the JsonRegex from public to private because it is only used inside the ClientUtils.

The method SanitizeFilename also used a Regex but because it is unused I removed it instead of refactoring it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

 * make JsonRegex private

 * on net7 and above use GeneratedRegex for JsonRegex

 * remove unused SanitizeFilename-Method
@wing328 wing328 added this to the 7.12.0 milestone Feb 26, 2025
@wing328 wing328 merged commit 5581a2d into OpenAPITools:master Feb 26, 2025
57 checks passed
@ffabss ffabss deleted the csharp-fix-syslib1045-generated-regex branch February 26, 2025 16:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants