Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ModelUtils.getUnusedSchema() #253

Merged
merged 3 commits into from
Jun 9, 2018
Merged

Conversation

jmini
Copy link
Member

@jmini jmini commented Jun 8, 2018

Fix #252

ModelUtils.getUnusedSchema() should also consider when Schemas are referenced in other Schemas. Implemented for:

  • array
  • object
  • maps
  • ComposedSchema
    • oneOf
    • anyOf
    • allOf
  • not

@jmini jmini changed the title [WIP] Fix ModelUtils.getUnusedSchema() Fix ModelUtils.getUnusedSchema() Jun 9, 2018
@jmini jmini removed the WIP Work in Progress label Jun 9, 2018
@jmini jmini added this to the 3.0.1 milestone Jun 9, 2018
@jmini
Copy link
Member Author

jmini commented Jun 9, 2018

@wing328 @jimschubert: ready for review.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I've not tested it locally.

@jmini jmini merged commit 992afd5 into OpenAPITools:master Jun 9, 2018
@jmini jmini deleted the issue252 branch June 9, 2018 09:56
@jimschubert
Copy link
Member

Thanks! I'll try to take a look at this later tonight to test it (even though it's already merged).

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 12, 2018
* master: (26 commits)
  Prepare 3.0.1 release (OpenAPITools#280)
  [typescript-angular] strict type checking (OpenAPITools#218)
  [C++ server] Adjust the names (script, sample folder, generator) to lang option (OpenAPITools#250)
  Removed warnings for packages included in SDK for Net Core 2.0 (OpenAPITools#269)
  [cli] Completions command for suggestions (OpenAPITools#213)
  [Java][RestTemplate] Fix query parameter URL encoding (OpenAPITools#260)
  [cpp-qt5] Remove std::shared_ptr from Qt5 (OpenAPITools#267)
  Adds some links to the README (OpenAPITools#261)
  Update sec.gpg.enc to binary encoded secret
  Add gpg --check-trustdb, limit gpg to master
  Re-do encrypted gpg and reference in settings.xml
  Fix trailing semicolons in after_success Travis CI scripts
  Use ubuntu keyserver instead of mit (due to timeout)
  [gradle] Plugin release management (OpenAPITools#201)
  Updates small typo in qna.md (OpenAPITools#262)
  Fix ModelUtils.getUnusedSchema() (OpenAPITools#253)
  Add JaxRS to bin/ensure-up-to-date (OpenAPITools#248)
  feat(security): add cookie-auth support (OpenAPITools#240)
  Add 'unblu inc.' to company list (OpenAPITools#246)
  put company list in alphabetical order (OpenAPITools#244)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants