Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Rust Server] Support multipart/form_data request bodies #2846

Merged
merged 5 commits into from
Aug 4, 2019
Merged

[Rust Server] Support multipart/form_data request bodies #2846

merged 5 commits into from
Aug 4, 2019

Conversation

richardwhiuk
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@frol, @farcaller, @bjgill

Description of the PR

  • Support multipart/form_data in the Rust Server generator
  • Add a new test API to test the change.
  • Update the examples to match

This has been written, and reviewed by myself, and others at @Metaswitch.

- Support multipart/form_data in the Rust Server
- Add a new test API to test the change.
- Update the examples to match
@richardwhiuk
Copy link
Contributor Author

CI Failure is in the elm code, which should be unrelated (e.g. it's seen in the merge of #2112).

@wing328
Copy link
Member

wing328 commented May 9, 2019

@richardwhiuk right, the CI failure (addressed in the latest master) has nothing to do with this PR.

If you are you free, let's have a quick chat via https://gitter.im (ID: wing328).

@wing328 wing328 added this to the 4.0.0 milestone May 9, 2019
@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@wing328 wing328 modified the milestones: 4.0.1, 4.0.2 May 31, 2019
Copy link
Contributor

@bjgill bjgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - looks good. I've just got a dependency version question and a minor style tweak.

@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019
@wing328 wing328 modified the milestones: 4.0.3, 4.1.0 Jul 9, 2019
@richardwhiuk richardwhiuk merged commit 6963e5e into OpenAPITools:master Aug 4, 2019
@richardwhiuk richardwhiuk deleted the multipart_form_data branch August 4, 2019 11:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants