Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dart2: update to work with dart 2.3.0 #2894

Merged
merged 2 commits into from
May 15, 2019
Merged

dart2: update to work with dart 2.3.0 #2894

merged 2 commits into from
May 15, 2019

Conversation

ircecho
Copy link
Contributor

@ircecho ircecho commented May 14, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

Dart 2.3.0 no longer works with http 0.11.+

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable to me.

@wing328 wing328 merged commit 049d24e into OpenAPITools:master May 15, 2019
@wing328
Copy link
Member

wing328 commented Jun 3, 2019

@ircecho thanks again for your contribution, which has been included in the v4.0.1 release (https://twitter.com/oas_generator/status/1135534738658062336)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants