Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Typescript] gets package npm version from API specification #2920

Merged
merged 2 commits into from
May 17, 2019

Conversation

karismann
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)

cc @lalau

Description of the PR

same as PR #2810 but for all typescript generator :

  • If no npmVersion is provided in additional properties, version from API specification is used. If none of them is provided then fallbacks to default version (1.0.0)
  • Refactoring npmName, npmVersion and Snapshot cliOptions (now defined in Abstract Class)

@karismann karismann changed the title Typescript npm refactor [Typescript][Angular] gets package npm version from API specification May 16, 2019
@karismann karismann changed the title [Typescript][Angular] gets package npm version from API specification [Typescript] gets package npm version from API specification May 16, 2019
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@wing328 wing328 added this to the 4.0.1 milestone May 17, 2019
@wing328 wing328 merged commit f550553 into OpenAPITools:master May 17, 2019
@karismann karismann deleted the typescript-npm-refactor branch May 17, 2019 07:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants