[C++] [Qt5] Set default base path and change constructor to const ref #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkrwork
reviewed
May 23, 2019
modules/openapi-generator/src/main/resources/cpp-qt5-client/api-header.mustache
Show resolved
Hide resolved
stkrwork
requested changes
May 23, 2019
modules/openapi-generator/src/main/resources/cpp-qt5-client/api-body.mustache
Outdated
Show resolved
Hide resolved
etherealjoy
force-pushed
the
cpp-qt5-basepath
branch
from
750a136 to
aedc2d9
Compare
stkrwork
reviewed
May 23, 2019
modules/openapi-generator/src/main/resources/cpp-pistache-server/main-api-server.mustache
Show resolved
Hide resolved
etherealjoy
commented
May 23, 2019
stkrwork
approved these changes
May 23, 2019
|
@etherealjoy thanks again for your contribution, which has been included in the v4.0.1 release (https://twitter.com/oas_generator/status/1135534738658062336) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Changes
QStringbasepath,hostcc:@ravinikam @stkrwork @MartinDelille