Add support for enums in Elm operations #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eriktim thanks for the PR. Let me review over the weekend. |
wing328
reviewed
May 27, 2019
| @@ -20,6 +20,25 @@ import Json.Decode as Decode | |||
| import Url.Builder as Url | |||
|
|
|||
|
|
|||
| type Status | |||
There was a problem hiding this comment.
@eriktim for Elm, is there any naming convention for enum?
In other languages, we may add a prefix/suffix (e.g. StatusEnum). This can help avoid naming conflicts with model names.
There was a problem hiding this comment.
Thanks @wing328
You have point here but custom types (as these would be called in Elm) are so common I'd rather not suffix them with Enum. Your remark does remind me I should actually start using Data.Status for all imported types to avoid conflicts. I'll do that in another PR.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Enumerations are interpreted as strings in Elm operations. This PR fixes this.
Fixes #2585.