Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[gradle plugin] Release 4.0.1 fixes #3051

Merged
merged 2 commits into from
Jun 2, 2019
Merged

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented Jun 1, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Covers some issues we had with reworking the gradle plugin publishing in 4.0.1 release:

  • Found that the plugin's version wasn't being updated in scripting (addressed in Update version to 4.0.2-SNAPSHOT #3047)
  • The publishPluginMavenPublicationToNexusRepository task only delivers a subset of files required by Sonatype in order for release (needed publishMavenJavaPublicationToNexusRepository)
  • username, password, and stagingProfileId weren't configured properly for the nexusPublishing task

This will need to be updated after #3047 is merged to change the version in gradle.properties to 4.0.2-SNAPSHOT.

@jimschubert jimschubert changed the title Release 4.0.1 fixes [gradle plugin] Release 4.0.1 fixes Jun 1, 2019
@jimschubert jimschubert requested a review from jmini June 1, 2019 22:26
* master:
  Update version to 4.0.2-SNAPSHOT (#3047)
  Map number to double time since float is also parsed as double in Qt5 C++ (#3046)
@jimschubert jimschubert merged commit f667eff into master Jun 2, 2019
@jimschubert jimschubert deleted the gradle-plugin-release-fixes branch June 2, 2019 03:36
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 5, 2019
* 4.1.x: (56 commits)
  sync master
  Update compatibility table
  Ruby client: escape path parameters (OpenAPITools#3039)
  [gradle plugin] Release 4.0.1 fixes (OpenAPITools#3051)
  Update version to 4.0.2-SNAPSHOT (OpenAPITools#3047)
  Map number to double time since float is also parsed as double in Qt5 C++ (OpenAPITools#3046)
  Prepare 4.0.1 release (OpenAPITools#3041)
  [gradle] Reworking publishing pipeline (OpenAPITools#2886)
  [typescript-fetch] Fix uploading files (OpenAPITools#2900)
  Resolves OpenAPITools#2962 - Add properties config to Maven parameters (OpenAPITools#2963)
  fix(golang): Check error of xml Encode (OpenAPITools#3027)
  [C++][Restbed] Add handler callback methods (OpenAPITools#2911)
  Remove null checks for C# value types (OpenAPITools#2933)
  [python-server] Support python 3.7 for all server-generators (OpenAPITools#2884)
  Use golang's provided method names (gin) (OpenAPITools#2983)
  [python] Adding constructor parameters to Configuration and improving documentation (OpenAPITools#3002)
  Add new option to maven plugin's readme (OpenAPITools#3025)
  Engine param in maven plugin. (OpenAPITools#2881)
  Added support for patterns on model properties (OpenAPITools#2948)
  [csharp] Make API response headers dictionary case insensitive (OpenAPITools#2998)
  ...
@wing328 wing328 added this to the 4.0.2 milestone Jun 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants