Fix inheritance with modelPrefix #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zomzog Thank you, I just freshly built from your branch and can confirm this solves the problem. Unfortunately, I'm not sure what's up with CircleCI. Seems like there was a problem unpacking some pre-requirements for the Hashkell test suite. |
tkalliom
reviewed
Jun 19, 2019
| Assert.assertEquals(codegenModel.vars.size(), 1); | ||
| } | ||
| @Test | ||
| public void modelWithSuffuxDoNotContainInheritedVars() { |
There was a problem hiding this comment.
There is a typo: ”Suffux” vs. ”Suffix”
|
cc @OpenAPITools/generator-core-team |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Check if inheritance parent exists with refName and not modelName.
I've done it on DefaultCodegen so it will impact all generators.
Fix #3150
@wing328
@jimschubert
@cbornet
@ackintosh
@jmini
@etherealjoy