Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added RxJava2 to java-vertx server codegen #3220

Closed
wants to merge 2 commits into from
Closed

Added RxJava2 to java-vertx server codegen #3220

wants to merge 2 commits into from

Conversation

jharmelink
Copy link
Contributor

@jharmelink jharmelink commented Jun 25, 2019

RxJava2 uses another base package. To support this package in java-vertx server codegen, a rxVersion2 boolean flag/option was added which defaults to false.

@phiz71 @wing328

@wing328
Copy link
Member

wing328 commented Jun 28, 2019

@jharmelink from what I understand, this is not a breaking change so you can file the change against the master branch (next patch release will be in a week)

@wing328 wing328 added this to the 4.0.3 milestone Jun 28, 2019
@wing328 wing328 changed the base branch from 4.1.x to master June 28, 2019 10:16
@wing328 wing328 changed the base branch from master to 4.1.x June 28, 2019 10:17
@jharmelink jharmelink changed the base branch from 4.1.x to master June 28, 2019 10:19
@jharmelink jharmelink changed the base branch from master to 4.1.x June 28, 2019 10:20
@jharmelink
Copy link
Contributor Author

I'll create a new PR for master

@jharmelink
Copy link
Contributor Author

Created new PR for master: #3240

@jharmelink jharmelink closed this Jun 28, 2019
@jharmelink jharmelink deleted the vertx_rxjava2 branch June 28, 2019 10:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants