Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[java] Support for number enum #3328

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

jmini
Copy link
Member

@jmini jmini commented Jul 10, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

Description of the PR

Fixes #447

The type number is mapped to java BigDecimal. This PR fixes the compilation issues that appears when enum values are defined.

Tested with:

openapi: 3.0.1
info:
  title: issue 447
  version: '1.0'
servers:
  - url: 'http://localhost:9999/'
paths:
  /ping:
    get:
      operationId: pingGet
      responses:
        '201':
          description: OK
components:
  schemas:
    NumberEnum:
      type: number
      enum:
        - 1.0
        - 2.5
        - 3.0

    SomeObject:
      type: object
      properties:
        aNum:
          type: number
          enum:
            - 5.0
            - 6.5
            - 7.0

@auto-labeler
Copy link

auto-labeler bot commented Jul 10, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit a0dd739 into OpenAPITools:master Jul 25, 2019
@wing328 wing328 added this to the 4.1.0 milestone Jul 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JAVA] enums with number type are not supported
2 participants